Caffeine-Powered Life

Why?

Just found this little gem from a project that went into production a week ago…


public MemoryStream GetReportBytes(string reportLocation, IEnumerable<Report> reportParameters) {

  var report = new ReportDocument();

  var location = new StringBuilder();

  location.Append(reportLocation);

  report.Load(location.ToString());    

  // etc...

}

You would think that this would be enough…


public MemoryStream GetReportBytes(string reportLocation, IEnumerable<Report> reportParameters) {

  var report = new ReportDocument();

  report.Load(reportLocation);  

  // etc...

I have got to start doing code reviews of the work that is making it out the door here.

Comments